[Emacs-diffs] emacs-26 6415b2d: Allow read-passwd to hide characters inserted by C-y. (Security fix.)

[Alan Mackenzie]

branch: emacs-26
commit 6415b2d40c13be2c5cd5f797718c391d1c4ce9e6
Author: Alan Mackenzie <address@hidden>
Commit: Alan Mackenzie <address@hidden>

    Allow read-passwd to hide characters inserted by C-y.  (Security fix.)
    
    This fixes bug #30186.  The with-silent-modifications was there to prevent
    records of text property manipulations being put into buffer-undo-list.  
These
    had been causing a significant slowdown in CC Mode with C-_ after a large
    C-y.  This CC Mode problem has since been solved by a different workaround.
    
    * lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of
    with-silent-modifications around the text property manipulations.
---
 lisp/subr.el | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index 052d9cd..64cbbd5 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3019,10 +3019,9 @@ remove properties specified by 
`yank-excluded-properties'."
                           run-start prop nil end)))
             (funcall fun value run-start run-end)
             (setq run-start run-end)))))
-    (with-silent-modifications
-      (if (eq yank-excluded-properties t)
-          (set-text-properties start end nil)
-        (remove-list-of-text-properties start end yank-excluded-properties)))))
+    (if (eq yank-excluded-properties t)
+        (set-text-properties start end nil)
+      (remove-list-of-text-properties start end yank-excluded-properties))))
 
 (defvar yank-undo-function)