[Emacs-diffs] master f02ce3b: ; Add fixme comments re password caching

[Glenn Morris]

branch: master
commit f02ce3b1e41c735c3b1a0da4e45434c7b8313bde
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>

    ; Add fixme comments re password caching
---
 lisp/gnus/mml-sec.el | 1 +
 lisp/gnus/smime.el   | 1 +
 lisp/net/tramp.el    | 1 +
 3 files changed, 3 insertions(+)

diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 3855d7b..dc10763 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -647,6 +647,7 @@ The passphrase is read and cached."
       (when passphrase
        (let ((password-cache-expiry (mml-secure-cache-expiry-interval
                                      (epg-context-protocol context))))
+         ;; FIXME test passphrase works before caching it.
          (password-cache-add password-cache-key-id passphrase))
        (mml-secure-add-secret-key-id password-cache-key-id)
        (copy-sequence passphrase)))))
diff --git a/lisp/gnus/smime.el b/lisp/gnus/smime.el
index d55cea7..ab2a5b0 100644
--- a/lisp/gnus/smime.el
+++ b/lisp/gnus/smime.el
@@ -238,6 +238,7 @@ password under `cache-key'."
          "Passphrase for secret key (RET for no passphrase): " cache-key)))
     (if (string= passphrase "")
        nil
+      ;; FIXME test passphrase works before caching it.
       (and passphrase cache-key (password-cache-add cache-key passphrase))
       passphrase)))
 
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 6011239..fe9f197 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -4459,6 +4459,7 @@ Invokes `password-read' if available, `read-passwd' else."
                                          auth-passwd))))
               ;; Try the password cache.
               (let ((password (password-read pw-prompt key)))
+                ;; FIXME test password works before caching it.
                 (password-cache-add key password)
                 password)
               ;; Else, get the password interactively.