emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-26 5c91ca8: Fix create_process bug breaking eudc-exp


From: Paul Eggert
Subject: [Emacs-diffs] emacs-26 5c91ca8: Fix create_process bug breaking eudc-expand-inline
Date: Sat, 10 Mar 2018 21:27:47 -0500 (EST)

branch: emacs-26
commit 5c91ca8f30098cb2593ca375daa82d25aef03ad7
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Fix create_process bug breaking eudc-expand-inline
    
    Problem reported by Thomas Fitzsimmons (Bug#30762).
    * src/process.c (create_process) [HAVE_PTYS]:
    Call setsid even if !PTY_FLAG.
---
 src/process.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/process.c b/src/process.c
index bccc3ac..b201e9b 100644
--- a/src/process.c
+++ b/src/process.c
@@ -2087,9 +2087,9 @@ create_process (Lisp_Object process, char **new_argv, 
Lisp_Object current_dir)
     {
       /* Make the pty be the controlling terminal of the process.  */
 #ifdef HAVE_PTYS
-      /* First, disconnect its current controlling terminal.  */
-      if (pty_flag)
-       setsid ();
+      /* First, disconnect its current controlling terminal.
+        Do this even if !PTY_FLAG; see Bug#30762.  */
+      setsid ();
       /* Make the pty's terminal the controlling terminal.  */
       if (pty_flag && forkin >= 0)
        {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]