emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] feature/bignum f822a25 2/2: Use mpz_sgn rather than compar


From: Tom Tromey
Subject: [Emacs-diffs] feature/bignum f822a25 2/2: Use mpz_sgn rather than comparisons against 0
Date: Thu, 9 Aug 2018 15:29:29 -0400 (EDT)

branch: feature/bignum
commit f822a2516d88eeb2118fbbc8554f155e86dfd74e
Author: Tom Tromey <address@hidden>
Commit: Tom Tromey <address@hidden>

    Use mpz_sgn rather than comparisons against 0
    
    * src/data.c (Fmod): Use mpz_sgn.
    * src/lisp.h (NATNUMP): Use mpz_sgn.
---
 src/data.c | 4 ++--
 src/lisp.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/data.c b/src/data.c
index 6512e7e..7d701fd 100644
--- a/src/data.c
+++ b/src/data.c
@@ -3251,8 +3251,8 @@ Both X and Y must be numbers or markers.  */)
       mpz_mod (result, *xmp, *ymp);
 
       /* Fix the sign if needed.  */
-      cmpr = mpz_cmp_si (result, 0);
-      cmpy = mpz_cmp_si (*ymp, 0);
+      cmpr = mpz_sgn (result);
+      cmpy = mpz_sgn (*ymp);
       if (cmpy < 0 ? cmpr > 0 : cmpr < 0)
        mpz_add (result, result, *ymp);
 
diff --git a/src/lisp.h b/src/lisp.h
index 9047d21..6726d69 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -2772,7 +2772,7 @@ INLINE bool
 NATNUMP (Lisp_Object x)
 {
   if (BIGNUMP (x))
-    return mpz_cmp_si (XBIGNUM (x)->value, 0) >= 0;
+    return mpz_sgn (XBIGNUM (x)->value) >= 0;
   return FIXNUMP (x) && 0 <= XFIXNUM (x);
 }
 INLINE bool



reply via email to

[Prev in Thread] Current Thread [Next in Thread]