scratch/package-vc-fixes 6484fb73d9 1/4: Avoid updating non-source packages in 'package-vc-update-all'

[Philip Kaludercic]

branch: scratch/package-vc-fixes
commit 6484fb73d94379f4744787a58dc655a7d68eda90
Author: Philip Kaludercic <philipk@posteo.net>
Commit: Philip Kaludercic <philipk@posteo.net>

    Avoid updating non-source packages in 'package-vc-update-all'
    
    * lisp/emacs-lisp/package-vc.el (package-vc-update-all): Check if a
    package is a source package.
    (package-vc-update): Add an assertion to verify this.
---
 lisp/emacs-lisp/package-vc.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index 1b7a51d185..3a856dc651 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -540,7 +540,8 @@ installed package."
   (interactive)
   (dolist (package package-alist)
     (dolist (pkg-desc (cdr package))
-      (package-vc-update pkg-desc))))
+      (when (package-vc-p pkg-desc)
+        (package-vc-update pkg-desc)))))
 
 (defun package-vc-update (pkg-desc)
   "Attempt to update the package PKG-DESC."
@@ -557,6 +558,7 @@ installed package."
   ;; `package-vc--unpack-1'.  Ugh...
   ;;
   ;; If there is a better way to do this, it should be done.
+  (cl-assert (package-vc-p pkg-desc))
   (letrec ((pkg-dir (package-desc-dir pkg-desc))
            (empty (make-symbol "empty"))
            (args (list empty empty empty empty))