emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 5dab172a173 1/2: allout.el: fix subtree expose numbering bug


From: Mattias Engdegård
Subject: master 5dab172a173 1/2: allout.el: fix subtree expose numbering bug
Date: Tue, 11 Apr 2023 06:18:55 -0400 (EDT)

branch: master
commit 5dab172a17320e93332ae6545738b37f4224f2de
Author: Mattias Engdegård <mattiase@acm.org>
Commit: Mattias Engdegård <mattiase@acm.org>

    allout.el: fix subtree expose numbering bug
    
    * lisp/allout.el (allout-process-exposed): Reverse the list of indices
    properly so that the correct numbering for nodes in a subtree is used.
    Avoid destructive reversing; the list may be a constant (literal).
    This flaw was revealed by an ignored-return-value warning.
---
 lisp/allout.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/allout.el b/lisp/allout.el
index 4d5d814ae01..be2fd632c69 100644
--- a/lisp/allout.el
+++ b/lisp/allout.el
@@ -5390,7 +5390,7 @@ Defaults:
     ;; not specified -- default it:
     (setq tobuf (concat "*" (buffer-name frombuf) " exposed*")))
   (if (listp format)
-      (nreverse format))
+      (setq format (reverse format)))
 
   (let* ((listified
          (progn (set-buffer frombuf)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]