[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] 02/02: [gnugo int] Use ‘loop ’ instead of ‘dolist’ + ‘destructuri
From: |
Thien-Thi Nguyen |
Subject: |
[elpa] 02/02: [gnugo int] Use ‘loop ’ instead of ‘dolist’ + ‘destructurin g-bind’. |
Date: |
Tue, 18 Mar 2014 10:42:55 +0000 |
ttn pushed a commit to branch master
in repository elpa.
commit 21ec57d69902d079dfd1bd9b2d15c97404b3ecca
Author: Thien-Thi Nguyen <address@hidden>
Date: Tue Mar 18 11:46:44 2014 +0100
[gnugo int] Use ‘loop’ instead of ‘dolist’ + ‘destructuring-bind’.
See:
<http://lists.gnu.org/archive/html/help-gnu-emacs/2014-03/msg00312.html>.
* packages/gnugo/gnugo.el (gnugo-board-mode): ...here.
---
packages/gnugo/gnugo.el | 38 +++++++++++++++++++-------------------
1 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/packages/gnugo/gnugo.el b/packages/gnugo/gnugo.el
index a332864..b89138c 100644
--- a/packages/gnugo/gnugo.el
+++ b/packages/gnugo/gnugo.el
@@ -1734,20 +1734,20 @@ In this mode, keys do not self insert.
'gnugo-option-history))
proc
board-size user-color handicap komi minus-l infile)
- (dolist (x '((board-size 19 "--boardsize")
- (user-color "black" "--color" "\\(black\\|white\\)")
- (handicap 0 "--handicap")
- (komi 0.0 "--komi")
- (minus-l nil "\\([^-]\\|^\\)-l[ ]*" "[^ ]+")
- (infile nil "--infile" "[ ]*[^ ]+")))
- (destructuring-bind (var default opt &optional rx) x
- (set var
- (or (when (string-match opt args)
- (let ((start (match-end 0)) s)
- (string-match (or rx "[0-9.]+") args start)
- (setq s (match-string 0 args))
- (if rx s (string-to-number s))))
- default))))
+ (loop for (var default opt &optional rx)
+ in '((board-size 19 "--boardsize")
+ (user-color "black" "--color" "\\(black\\|white\\)")
+ (handicap 0 "--handicap")
+ (komi 0.0 "--komi")
+ (minus-l nil "\\([^-]\\|^\\)-l[ ]*" "[^ ]+")
+ (infile nil "--infile" "[ ]*[^ ]+"))
+ do (set var
+ (or (when (string-match opt args)
+ (let ((start (match-end 0)) s)
+ (string-match (or rx "[0-9.]+") args start)
+ (setq s (match-string 0 args))
+ (if rx s (string-to-number s))))
+ default)))
(gnugo-put :user-color user-color)
(let ((proc-args (split-string args)))
(gnugo-put :proc-args proc-args)
@@ -1759,11 +1759,11 @@ In this mode, keys do not self insert.
;; Emacs is too protective sometimes, blech.
(set-process-query-on-exit-flag proc nil)
(when (or minus-l infile)
- (dolist (x '((board-size "query_boardsize")
- (komi "get_komi")
- (handicap "get_handicap")))
- (destructuring-bind (prop q) x
- (set prop (string-to-number (gnugo-query q))))))
+ (loop for (prop q)
+ in '((board-size "query_boardsize")
+ (komi "get_komi")
+ (handicap "get_handicap"))
+ do (set prop (string-to-number (gnugo-query q)))))
(gnugo-put :diamond (substring (process-name proc) 5))
(gnugo-put :gnugo-color (gnugo-other user-color))
(gnugo-put :highlight-last-move-spec