emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] 01/01: * update-archive.sh (announce_new): Avoid "eval" and don't


From: Stefan Monnier
Subject: [elpa] 01/01: * update-archive.sh (announce_new): Avoid "eval" and don't assume pkg names don't start with -.
Date: Thu, 22 May 2014 14:39:32 +0000

monnier pushed a commit to branch master
in repository elpa.

commit 995856a19b691c107b806b8103828f9a01ce32b1
Author: Stefan Monnier <address@hidden>
Date:   Thu May 22 10:39:23 2014 -0400

    * update-archive.sh (announce_new): Avoid "eval" and don't assume pkg names
    don't start with -.
---
 admin/update-archive.sh |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/admin/update-archive.sh b/admin/update-archive.sh
index 680298b..de4a0a4 100755
--- a/admin/update-archive.sh
+++ b/admin/update-archive.sh
@@ -50,8 +50,9 @@ signal_error () {
 announce_new () {
     if [ "yes" != "$announce" ]; then return; fi
     pv="$1"
-    eval $(echo "$pv" | sed -e 's/^\(.*\)-\([^-]*\)$/pkg="\1" ver="\2"/')
-    test "$pkg" && test "$ver" || signal_error "bad PKG-VER: $pv"
+    pkg="$(echo "$pv" | sed -e 's/^\(.*\)-\([^-]*\)\.[^-.]*$/\1/')"
+    ver="$(echo "$pv" | sed -e 's/^\(.*\)-\([^-]*\)\.[^-.]*$/\2/')"
+    if [ -z "$pkg" ] || [ -z "$ver" ]; then signal_error "bad PKG-VER: $pv"; fi
     send_mail "$a_email" "[GNU ELPA] $pkg version $ver" <<ENDDOC
 Version $ver of GNU ELPA package $pkg has just been released.
 You can now find it in M-x package-list RET.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]