[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/exwm edc70eb 22/64: Remove redundant code caused by the
From: |
Chris Feng |
Subject: |
[elpa] externals/exwm edc70eb 22/64: Remove redundant code caused by the concurrency of events |
Date: |
Thu, 17 Sep 2015 23:17:57 +0000 |
branch: externals/exwm
commit edc70eb6616b818463c94b5ab8c9e3f1dfd177c9
Author: Chris Feng <address@hidden>
Commit: Chris Feng <address@hidden>
Remove redundant code caused by the concurrency of events
With the introduction of ch11ng/address@hidden, many weird behaviors should
disappear. These include by not limit to
* race conditions when managing a window (a workaround is provided in
@14628a9)
* race conditions when unmanaging a window
This commit removes some corresponding code.
---
exwm-manage.el | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/exwm-manage.el b/exwm-manage.el
index 8bf118e..6c22948 100644
--- a/exwm-manage.el
+++ b/exwm-manage.el
@@ -42,30 +42,21 @@ corresponding buffer.")
(when reply ;nil when destroyed
(setq exwm--geometry reply))))))
-(defvar exwm-manage--manage-window-queue nil
- "List of window IDs to prevent race conditions.")
-
(defun exwm-manage--manage-window (id)
"Manage window ID."
(exwm--log "Try to manage #x%x" id)
(setq exwm-input--focus-lock t)
(catch 'return
;; Ensure it's not managed
- (when (or (assoc id exwm--id-buffer-alist)
- (memq id exwm-manage--manage-window-queue))
+ (when (assoc id exwm--id-buffer-alist)
(exwm--log "#x%x is already managed" id)
(throw 'return 'managed))
- (push id exwm-manage--manage-window-queue) ;prevent reentering
;; Ensure it's alive
(when (xcb:+request-checked+request-check exwm--connection
(make-instance 'xcb:ChangeWindowAttributes
:window id :value-mask xcb:CW:EventMask
:event-mask exwm--client-event-mask))
- (setq exwm-manage--manage-window-queue
- (delq id exwm-manage--manage-window-queue)) ;cleanup
(throw 'return 'dead))
- (setq exwm-manage--manage-window-queue
- (delq id exwm-manage--manage-window-queue)) ;cleanup (late enough)
(with-current-buffer (generate-new-buffer "*EXWM*")
(push `(,id . ,(current-buffer)) exwm--id-buffer-alist)
(exwm-mode)
- [elpa] externals/exwm 86764d2 07/64: Add basic RandR support, (continued)
- [elpa] externals/exwm 86764d2 07/64: Add basic RandR support, Chris Feng, 2015/09/17
- [elpa] externals/exwm 1e36a22 13/64: Check buffer mode in exwm-reset, Chris Feng, 2015/09/17
- [elpa] externals/exwm 14628a9 16/64: Fix race conditions when managing a window, Chris Feng, 2015/09/17
- [elpa] externals/exwm 5298489 18/64: Fix some input focus issues, Chris Feng, 2015/09/17
- [elpa] externals/exwm 3b9d0dd 17/64: Fixes for manage/unmanage window, Chris Feng, 2015/09/17
- [elpa] externals/exwm 42f4ec6 20/64: Show moved window by default, Chris Feng, 2015/09/17
- [elpa] externals/exwm 36bb579 21/64: Refresh when minibuffer grows (fix #10), Chris Feng, 2015/09/17
- [elpa] externals/exwm 2ad1a89 14/64: Various input fixes, Chris Feng, 2015/09/17
- [elpa] externals/exwm 84f0f03 15/64: Fix input focus lost after closing window, Chris Feng, 2015/09/17
- [elpa] externals/exwm 63402b0 19/64: Correct layout refresh problems, Chris Feng, 2015/09/17
- [elpa] externals/exwm edc70eb 22/64: Remove redundant code caused by the concurrency of events,
Chris Feng <=
- [elpa] externals/exwm 2d4104a 23/64: Fix emacsclient bugs, Chris Feng, 2015/09/17
- [elpa] externals/exwm 24b964b 25/64: Ignore repeated `MappingNotify` events, Chris Feng, 2015/09/17
- [elpa] externals/exwm 801185c 27/64: Fix buffer switch problems, Chris Feng, 2015/09/17
- [elpa] externals/exwm 1ce18af 28/64: Center floating windows by default, Chris Feng, 2015/09/17
- [elpa] externals/exwm 048994c 24/64: Remove redundant code caused by the concurrency of events (continued), Chris Feng, 2015/09/17
- [elpa] externals/exwm 35560a4 30/64: Minor fixes for emacsclient, Chris Feng, 2015/09/17
- [elpa] externals/exwm b755296 26/64: Remove redundant code caused by the concurrency of events (contd, 2), Chris Feng, 2015/09/17
- [elpa] externals/exwm 7bfd429 33/64: Honor `value-mask` field in ConfigureRequest event, Chris Feng, 2015/09/17
- [elpa] externals/exwm dba43b0 32/64: Fix input focus stealing, Chris Feng, 2015/09/17
- [elpa] externals/exwm d998b42 34/64: Provide hooks run when the floating state of a window changes (close #28), Chris Feng, 2015/09/17