[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ebdb 722e2c3 211/350: Mild hack to make pop up windows
From: |
Eric Abrahamsen |
Subject: |
[elpa] externals/ebdb 722e2c3 211/350: Mild hack to make pop up windows work well |
Date: |
Mon, 14 Aug 2017 11:46:38 -0400 (EDT) |
branch: externals/ebdb
commit 722e2c38013ddb70dd4496b0512e21a23d713081
Author: Eric Abrahamsen <address@hidden>
Commit: Eric Abrahamsen <address@hidden>
Mild hack to make pop up windows work well
* ebdb-com.el (ebdb-pop-up-window): Make sure window splits. See code
comment.
---
ebdb-com.el | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/ebdb-com.el b/ebdb-com.el
index a33620c..901797f 100644
--- a/ebdb-com.el
+++ b/ebdb-com.el
@@ -975,8 +975,19 @@ buffer."
(> (window-total-width split-window)
(window-total-height split-window)))
'horiz
- 'vert)))
-
+ 'vert))
+ ;; This is a hack, necessitated by my ignorance about window
+ ;; splitting. We were originally using `split-window'
+ ;; directly; I changed that because it seemed better to be
+ ;; using a higher-level function, and because
+ ;; `display-buffer-pop-up-window' sets the `quit-restore'
+ ;; window parameter correctly. But it's also too clever, and
+ ;; won't split windows on small screens, and we essentially
+ ;; don't ever want *EBDB* to reuse an existing window.
+ ;; Probably I should just go back to using `split-window',
+ ;; and figure out how to manually set `quit-restore'.
+ (split-width-threshold (/ split-width-threshold 2))
+ (split-height-threshold (/ split-height-threshold 2)))
(cond (buffer-window
;; It's already visible, re-use it.
nil)
- [elpa] externals/ebdb a8e44ee 175/350: Update company-ebdb for new search behavior, (continued)
- [elpa] externals/ebdb a8e44ee 175/350: Update company-ebdb for new search behavior, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb ece91cb 176/350: Remove spurious ebdb-record-search implementation, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 86a3aa9 180/350: Change signature of ebdb-undisplay-records, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 05cf7ec 184/350: New ebdb-message-buffer-name subst, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb ae377c1 199/350: Use ebdb-field-search in notes-type record searches, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 54bb078 200/350: Remove final references to ebdb-print, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 072bb74 205/350: ebdb-parse-i18n must also accept a slots argument, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 79ed878 201/350: Handle formatting to a fake *EBDB* buffer, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 1ae4bbf 206/350: Provide internationalized ebdb-string and ebdb-parse for phones, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 0cb406e 210/350: Expand ebdb-test-save-vars to save ebdb-db-list as well, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 722e2c3 211/350: Mild hack to make pop up windows work well,
Eric Abrahamsen <=
- [elpa] externals/ebdb 374919e 196/350: Fixes to proper name formatting, part III, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 0ccfc0a 215/350: Write generics for ebdb-db-add/remove-record, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 498a580 214/350: Allow user transformation of search strings, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 760fd91 204/350: More informative warning when deleting record fields, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 762f027 219/350: Add Makefile, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 325426e 207/350: Add ebdb-complete.el (#32), Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb ea13778 221/350: Autoload calendar-absolute-from-gregorian, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb af13080 218/350: Support sending text messages via Signal, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 94749fd 224/350: Expand gnus-user-format-function-%s, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb c9f8f33 226/350: Be more when careful migrating timestamps, Eric Abrahamsen, 2017/08/14