Re: [Orgmode] org-agenda-filter-by-tag doesn't work with custom effort property

[Daniel Clemente]

El dc, feb 25 2009, Carsten Dominik va escriure:
> On Feb 24, 2009, at 3:52 PM, Daniel Clemente wrote:
>
>>
>>  Hi, I would like to contribute 1 byte to org-mode; it's an "a":
>>
>>
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -4407,7 +4407,7 @@ to switch to narrowing."
>>                  (lambda (x) (if (cdr x) (char-to-string (cdr x)) ""))
>>                  alist ""))
>>      (efforts (org-split-string
>> -              (or (cdr (assoc (concat org-effort-property "_ALL")
>> +              (or (cadr (assoc (concat org-effort-property "_ALL")
>>                                org-global-properties))
>>                    "0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 7:00 8:00"
>
> I don't think this is correct.
>
> What are the symptoms of the problem you encounter?

  Before describing the problem: the (or ) was taking either the (cdr ) or "0 
0:10…". But cdr always return a list (not a string), so if the cdr is used, the 
result will be a list, and this is wrong because it org-split-string expects a 
string, not a list.

  The problem can be reproduced with:
1. C-c a
2. a
3. /

  I get:
Debugger entered--Lisp error: (wrong-type-argument stringp ("0 0:10 0:30 1:00 
2:00 3:00 4:00 5:00 6:00 12:00 18:00 24:00 30:00"))
  string-match("[ \f    \n…]+" ("0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 
12:00 18:00 24:00 30:00") 0)
  org-split-string(("0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 12:00 18:00 
24:00 30:00"))
  org-agenda-filter-by-tag(nil)
  call-interactively(org-agenda-filter-by-tag nil nil)



  I'm using:
(add-to-list 'org-global-properties '("Effort_ALL" "0 0:10 0:30 1:00 2:00 3:00 
4:00 5:00 6:00 12:00 18:00 24:00 30:00"))

  org-mode 6.21b (from Emacs from Bazaar of 24-2-2009)


-- Daniel