Re: [Orgmode] Re: [PATCH] little fixes for attachment git commiting

[David Maus]

Łukasz Stelmach wrote:
>David Maus <address@hidden> writes:

>> Łukasz Stelmach wrote:
>>>David Maus <address@hidden> writes:
>>
>>>> Łukasz Stelmach wrote:
>>>>>The other one helps if for some reason the file one would like to add
>>>>>matches an entry in a .gitignore file. I suppose no one puts anything in
>>>>>the org-attach-directory by hand, so anything that goes there is by
>>>>>intention.
>>>>>http://github.com/steelman/steelman-org-mode/commit/8ade081fd5a331cc61f8f8a6f8cf5a92ff8881d5
>>>>
>[...]
>>>> In addition one might explicitly include the content of attachment
>>>> directories using the negating operator in .gitignore.
>>>This might be a better solution indeed.
>>
>> Yep.  Though about it: Using the -f switch overrides any configuration
>> of git a user may have made in a system wide, user or repository
>> specific gitignore -- that shouldn't be turned on by default or even
>> enforced in the source.

>You're right, I admit. Please forget this commit. Take only the one
>about xargs --no-run-if-empty

>http://github.com/steelman/steelman-org-mode/commit/8dc5033d13af1d0aa6f1094a1775cc1a1ec33c67

Looks good to me.  It handles the case when "git ls-files --deleted
-z" returns an empty string (nothing to delete) that is currently
handled by rm silently issuing an error message.

Regards
 -- David

-- 
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... address@hidden
Email..... address@hidden

pgpvB58SdKZgi.pgp
Description: PGP signature