[Orgmode] Re: [PATCH] little fixes for attachment git commiting

[Łukasz Stelmach]

Carsten Dominik <address@hidden> writes:

> On Feb 19, 2010, at 11:59 AM, Łukasz Stelmach wrote:
>
>> Carsten Dominik <address@hidden> writes:
>>
>>> On Feb 16, 2010, at 8:04 PM, Łukasz Stelmach wrote:
>>>
>>>> There are two very small commits which iron some wrinkles. Both on
>>>> org-attach-git-commit branch of
>>>> git://github.com/steelman/steelman-org-mode.git
>>>>
>>>> The first prevents git from running on an empty set of deleted
>>>> files.
>>>
>>> Why is that a problem?  I am hesitating to apply this patch, because
>>> on my Mac OS 10.5, xargs does know the --no-run-if-empty argument.
>>                           ^^^^^^^^^[*]
>>
>> When xargs launches git rm without file arguments git emmits usage
>>
>> --8<---------------cut here---------------start------------->8---
>> usage: git rm [options] [--] <file>...
[...]
>> --8<---------------cut here---------------end--------------->8---
>>
>> message which in this situation is a bit confusing and *suggests*
>> somehting might have gone wrong. And of course a shell output buffer
>> pops up.
>>
>> [*] does || doesn't?
>
> Does not.
>
> Do you actually get to see this error message?  Where?

Everytime I attach a file and there is no deleted files which "git
ls-files --deleted" would list.  Try running

git ls-files --deleted -z | xargs -0 git rm

when there is no deleted uncommited files in a repository. git's return
code is 123 so Emacs thinks it is an error.


-- 
Miłego dnia,
Łukasz Stelmach