Re: [Orgmode] [Babel] Patch for "Evaluation aborted"

[Eric Schulte]

Hi Seb,

Nice idea, I've just pushed up a patch which improves this message.

Best -- Eric

Sébastien Vauban <address@hidden> writes:

> Hi Eric and Dan,
>
> I was puzzled this morning by a message "evalution aborted" without any extra
> info. "Aborted" made me think there was an error, so I toggle debug-on-error,
> but it did not give me any more insight on the problem.
>
> After searching for the message in the code base, I found it in =ob.el= and
> understood it was when eval was disabled (set to =no= or =never=).
>
> In this case, I would ask for a clearer message:
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index 584d627..5bb0d5c 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -219,7 +219,7 @@ of potentially harmful code."
>                (not (yes-or-no-p
>                      (format "Evaluate this%scode on your system? "
>                              (if info (format " %s " (nth 0 info)) " "))))))
> -     (prog1 nil (message "evaluation aborted"))
> +     (prog1 nil (message "Evaluation disabled by user (option)."))
>        t)))
>  
>  ;;;###autoload
>
> Feel free to change it to something better, but, in any case, I'd prefer
> "disabled" over "aborted". At least in my mind, "disabled" is not related to
> "error", while "aborted" is (in my mind, or in my Frenglish).
>
> Best regards,
>   Seb