[Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

[Matt Lundin]

Bastien Guerry <address@hidden> writes:

> Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted".

>> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a
>> possible default span if it is set.
>> 
>> Signed-off-by: Julien Danjou <address@hidden>
>> ---
>>  lisp/org-agenda.el |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>> 
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index 0cd620c..0d695b5 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'."
>>    (setq org-agenda-last-arguments (list include-all start-day span))
>>    (org-compile-prefix-format 'agenda)
>>    (org-set-sorting-strategy 'agenda)
>> -  (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays 
>> org-agenda-span)))
>> +  (let* ((span (org-agenda-ndays-to-span (or span
>> +                                         org-agenda-current-span
>> +                                         org-agenda-ndays
>> +                                         org-agenda-span)))
>>       (today (org-today))
>>       (sd (or start-day today))
>>       (ndays (org-agenda-span-to-ndays span sd))
>> -- 

This patch breaks custom commands --- i.e., if one binds org-agenda-span
in a custom command, it seems to be overridden by the span of whatever
agenda command one last called (i.e., org-agenda-current-span).

Steps to replicate:

1. (setq org-agenda-span 'day)

2. M-x org-agenda-list

3. Check the value of org-agenda-current-span => day

4. Call the following custom command:

(setq org-agenda-custom-commands
      '(("c" "Calendar" agenda ""
         ((org-agenda-span 'week)
          (org-agenda-start-on-weekday 0)       
          (org-agenda-time-grid nil)
          (org-agenda-entry-types '(:timestamp :sexp))
          (org-agenda-prefix-format " %-12:t ")
          (org-deadline-warning-days 0)
          (org-agenda-include-all-todo nil)
          (org-agenda-repeating-timestamp-show-all t)
          ))))

This results in only a day view because org-agenda-current-span is still
'day.

Best,
Matt