[Orgmode] Bug: Tangling indirect buffers [7.4]

[Shaun Johnson]

Tangling from an indirect buffer fails with the following stack trace:

  Debugger entered--Lisp error: (wrong-type-argument stringp nil)
    file-name-nondirectory(nil)
    (message "tangled %d code block%s from %s" block-counter (if (= block-counter 1) "" 
"s") (file-name-nondirectory (buffer-file-name ...)))
    (let ((block-counter 0) (org-babel-default-header-args ...) path-collector) (mapc (lambda ... ...) 
(org-babel-tangle-collect-blocks lang)) (message "tangled %d code block%s from %s" block-counter 
(if ... "" "s") (file-name-nondirectory ...)) (when org-babel-post-tangle-hook (mapc ... 
path-collector)) path-collector)
    (save-excursion (let (... ... path-collector) (mapc ... ...) (message "tangled 
%d code block%s from %s" block-counter ... ...) (when org-babel-post-tangle-hook 
...) path-collector))
    org-babel-tangle()
    call-interactively(org-babel-tangle nil nil)

The problem seems to be in this fragment of org-babel-tangle:

      (message "tangled %d code block%s from %s" block-counter
               (if (= block-counter 1) "" "s")
               (file-name-nondirectory (buffer-file-name (current-buffer))))

On an indirect buffer buffer-file-name returns nil, replacing this by:

      (message "tangled %d code block%s from %s" block-counter
               (if (= block-counter 1) "" "s")
               (file-name-nondirectory (buffer-file-name
                                    (or (buffer-base-buffer) 
(current-buffer)))))

seems to do the right thing.

Shaun.

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------



Emacs  : GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600)
 of 2010-05-08 on G41R2F1
Package: Org-mode version 7.4

current state:
==============
(setq
 org-emphasis-alist '(("*" bold "<b>" "</b>") ("/" italic "<i>" "</i>")
                      ("_" underline "<span 
style=\"text-decoration:underline;\">"
                       "</span>")
                      ("=" org-code "<code>" "</code>" verbatim)
                      ("~" org-verbatim "<code>" "</code>" verbatim))
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-speed-command-hook '(org-speed-command-default-hook 
org-babel-speed-command-hook)
 org-agenda-include-diary t
 org-clock-into-drawer "CLOCK"
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-babel-tangle-lang-exts '(("magik" . "magik") ("emacs-lisp" . "el"))
 org-id-method 'org
 org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
 org-log-note-clock-out t
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-hide-emphasis-markers t
 org-tab-first-hook '(org-hide-block-toggle-maybe 
org-src-native-tab-command-maybe
                      org-babel-hide-result-toggle-maybe)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
                     org-src-mode-configure-edit-buffer)
 org-confirm-shell-link-function 'yes-or-no-p
 org-reveal-start-hook '(org-decrypt-entry)
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-directory "~/Org"
 org-babel-pre-tangle-hook '(save-buffer)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
                  org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-export-preprocess-before-normalizing-links-hook 
'(org-remove-file-link-modifiers)
 org-mode-hook '((lambda nil
                  (org-add-hook (quote change-major-mode-hook)
                   (quote org-babel-show-result-all) (quote append) (quote 
local))
                  )
                 (lambda nil
                  (setq org-mouse-context-menu-function (quote 
org-mouse-context-menu))
                  (when (memq (quote context-menu) org-mouse-features)
                   (org-defkey org-mouse-map [mouse-3] nil)
                   (org-defkey org-mode-map [mouse-3]
                    (quote org-mouse-show-context-menu))
                   )
                  (org-defkey org-mode-map [down-mouse-1] (quote 
org-mouse-down-mouse))
                  (when (memq (quote context-menu) org-mouse-features)
                   (org-defkey org-mouse-map [C-drag-mouse-1]
                    (quote org-mouse-move-tree))
                   (org-defkey org-mouse-map [C-down-mouse-1]
                    (quote org-mouse-move-tree-start))
                   )
                  (when (memq (quote yank-link) org-mouse-features)
                   (org-defkey org-mode-map [S-mouse-2] (quote 
org-mouse-yank-link))
                   (org-defkey org-mode-map [drag-mouse-3] (quote 
org-mouse-yank-link))
                   )
                  (when (memq (quote move-tree) org-mouse-features)
                   (org-defkey org-mouse-map [drag-mouse-3]
                    (quote org-mouse-move-tree))
                   (org-defkey org-mouse-map [down-mouse-3]
                    (quote org-mouse-move-tree-start))
                   )
                  (when (memq (quote activate-stars) org-mouse-features)
                   (font-lock-add-keywords nil
                    (\`
                     (((\, outline-regexp) 0
                       (\`
                        (face org-link mouse-face highlight keymap (\, 
org-mouse-map)))
                       (quote prepend))
                      )
                     )
                    t)
                   )
                  (when (memq (quote activate-bullets) org-mouse-features)
                   (font-lock-add-keywords nil
                    (\`
                     (("^[         ]*\\([-+*]\\|[0-9]+[.)]\\) +"
                       (1
                        (\`
                         (face org-link keymap (\, org-mouse-map) mouse-face 
highlight)
                         )
                        (quote prepend))
                       )
                      )
                     )
                    t)
                   )
                  (when (memq (quote activate-checkboxes) org-mouse-features)
                   (font-lock-add-keywords nil
                    (\`
                     (("^[         ]*\\([-+*]\\|[0-9]+[.)]\\) +\\(\\[[ X]\\]\\)"
                       (2
                        (\` (face bold keymap (\, org-mouse-map) mouse-face 
highlight))
                        t)
                       )
                      )
                     )
                    t)
                   )
                  (defadvice org-open-at-point
                   (around org-mouse-open-at-point activate)
                   (let ((context (org-context)))
                    (cond ((assq :headline-stars context) (org-cycle))
                     ((assq :checkbox context) (org-toggle-checkbox))
                     ((assq :item-bullet context)
                      (let ((org-cycle-include-plain-lists t)) (org-cycle)))
                     (t ad-do-it))
                    )
                   )
                  )
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook org-show-block-all 
append
                    local]
                   5]
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook 
org-babel-show-result-all
                    append local]
                   5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point 
org-babel-execute-safely-maybe)
 org-emphasis-regexp-components '("        ('\"" "-         .,:?;'\")_" "    
\n,\"'" "." 1)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-mode-hook '((lambda nil
                         (setq org-mouse-context-menu-function
                          (quote org-mouse-agenda-context-menu))
                         (org-defkey org-agenda-mode-map [mouse-3]
                          (quote org-mouse-show-context-menu))
                         (org-defkey org-agenda-mode-map [down-mouse-3]
                          (quote org-mouse-move-tree-start))
                         (org-defkey org-agenda-mode-map [C-mouse-4]
                          (quote org-agenda-earlier))
                         (org-defkey org-agenda-mode-map [C-mouse-5]
                          (quote org-agenda-later))
                         (org-defkey org-agenda-mode-map [drag-mouse-3]
                          (quote
                           (lambda (event) (interactive "e")
                            (case (org-mouse-get-gesture event)
                             (:left (org-agenda-earlier 1))
                             (:right (org-agenda-later 1)))
                            )
                           )
                          )
                         )
                        )
 org-export-interblocks '((lob org-babel-exp-lob-one-liners)
                          (src org-babel-exp-inline-src-blocks))
 org-occur-hook '(org-first-headline-recenter)
 org-export-preprocess-before-selecting-backend-code-hook 
'(org-beamer-select-beamer-code)
 org-modules '(org-bbdb org-bibtex org-gnus org-id org-info org-jsinfo org-irc 
org-mew
               org-mhe org-rmail org-vm org-wl org-w3m)
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
                               org-beamer-auto-fragile-frames
                               org-beamer-place-default-actions-for-lists)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-fontify-emphasized-text nil
 org-export-blocks '((src org-babel-exp-src-blocks nil)
                     (comment org-export-blocks-format-comment t)
                     (ditaa org-export-blocks-format-ditaa nil)
                     (dot org-export-blocks-format-dot nil))
 )