[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [patch] Don't output preamble DIV if its contents is empty
From: |
Sebastien Vauban |
Subject: |
Re: [O] [patch] Don't output preamble DIV if its contents is empty |
Date: |
Sat, 29 Oct 2011 21:28:55 +0200 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (windows-nt) |
Hi Bastien,
Bastien wrote:
> "Sebastien Vauban" <address@hidden> writes:
>>> are there adverse effects when an empty div is in the file?
>>
>> Yes, there are, reason for such patch.
>
> I understand the reasons and I have applied the patch -- please provide a
> ChangeLog next time.
I can assure you that I'll do, as I just began doing...
> You can provide it like you just did (with the tag filter patch), but even
> better is to include the ChangeLog in the commit log, after the first line.
> Check available commits on http://orgmode.org/w/org-mode.git to get the
> idea.
OK. Understood.
Question: why do we do like that (inserting the ChangeLog contents after the
first line of the commit log)? Is it automatically used somewhere to generate
a proper ChangeLog file?
Why isn't there a real shared ChangeLog file in the repository?
I want to know, because I want to learn more about all the aspects of this
project in particular, but as well collaborative work in general...
Best regards,
Seb
--
Sebastien Vauban