emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] functions from cl package called at runtime


From: Eric Schulte
Subject: Re: [O] functions from cl package called at runtime
Date: Thu, 19 Jan 2012 11:08:27 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)

Thanks for catching this, I've just pushed up a fix.

Is there a convention for which macros from cl-macs are allowable and
which are forbidden?  For example `flet' is used extensively throughout
the Org-mode code base.  Is the convention that macros are allowable
while functions are not?

Also, while intersection below is a function defined in cl-seq, the use
of `intersection' in ob.el refers to a local function and not the cl-seq
function, so it should be fine.

Thanks,

Achim Gratz <address@hidden> writes:

> The sources in ob.el have picked up several runtime invocations to
> functions from the cl package via two commits from Eric:
>
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file"))
> fc92b2e2 lisp/ob.el   (rx (gensym "rx")))
> abf3060e lisp/ob.el (flet ((intersection (as bs)
> abf3060e lisp/ob.el                      (intersection (cdr as) bs)))))
> abf3060e lisp/ob.el   (intersection (case context
>
> These may need to be revised...
>
>
> Regards,
> Achim.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]