[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [Bug] Regression w/ insert into tables in overwrite-mode
From: |
Bastien |
Subject: |
Re: [O] [Bug] Regression w/ insert into tables in overwrite-mode |
Date: |
Tue, 27 Mar 2012 23:53:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) |
Hi Achim,
Achim Gratz <address@hidden> writes:
> Achim Gratz <address@hidden> writes:
>
>> Commit 00040e7 by David Maus has introduced a regression when inserting
>> into org tables while overwrite mode is on. For each character inserted
>> into a table cell, the cell (and the whole table row) gets shortened by
>> one character.
>>
>> If the change can not be reverted, the deletion must not
>> happen when overwrite mode is on, maybe through something like this:
>>
>> (if (not overwrite-mode) (delete-char -1))
>
> The change cannot be reverted, since Emacs24 issues a compile-time
> warning about using delete-backward-char, even though that warning has
> been dropped from the doc string... so it needs to be protected or
> replaced by an org-specific version that honors overwrite mode.
I reverted David's change and replaced `delete-backward-char'
by `backward-delete-char', which isn't caught by the compiler*.
`backward-delete-char' is remapped to `delete-backward-char'
by Emacs and `delete-backward-char' is remapped by Org to
`org-delete-backward-char'.
Thanks for your patience on this one!
* This looks weird that an alias isn't caught by the compiler,
I'll let Emacs devs know about this.
--
Bastien