[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-e-latex--collect-errors
From: |
Philipp Kroos |
Subject: |
Re: [O] [PATCH] org-e-latex--collect-errors |
Date: |
Sat, 15 Sep 2012 15:08:09 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Yes, you're completely right. I missed that.
Should be better now, I moved the defcustom to the end of the
compilation-customs-block.
Thank you, Philipp
On Sat, Sep 15, 2012 at 02:28:05PM +0200, Nicolas Goaziou wrote:
> Hello,
>
> Philipp Kroos <address@hidden> writes:
>
> > the attached patch tries to solve two issues:
> > - Currently, org-e-latex--collect-errors only finds errors in
> > pdf.*latex-logs. I removed the `pdf`, cause most of the time I'm using
> > xelatex which wouldn't match. I don't know if this is generic enough
> > for all engines though.
> > - Occasionally, I'm running into errors currently not matched (Like
> > 'Runaway argument'). What about the customizable
> > org-e-latex-known-errors introduced in the patch that would allow the
> > user to adjust the matcher to his needs and the used engine?
> > This also makes the code more concise.
> >
> > What do you think about this?
> > (The first customizable I ever wrote, I think it's correct like this, is
> > it?)
>
> I think this patch is good, but would you mind moving your defcustom in
> the appropriate section within org-e-latex.el ? Also, there are spurious
> blank lines in this patch. Could you remove them too?
>
> Thank you.
>
>
> Regards,
>
> --
> Nicolas Goaziou
0001-org-e-latex-Introduced-org-e-latex-known-errors.patch
Description: Text document