[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert
From: |
Eric Schulte |
Subject: |
Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results |
Date: |
Fri, 08 Mar 2013 15:09:45 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Achim Gratz <address@hidden> writes:
> Aaron Ecay writes:
>> In order for the cache feature to work, the hash of a finished
>> computation must be inserted. But, this is not currently done for src
>> blocks which have the option :results none. Thus, we should insert a
>> dummy empty result for these blocks, which will hold the hash.
>
> Getting a results block when specifying ":results none" feels a bit
> strange.
I would agree. I don't believe *any* changes should take place in the
buffer when a code block is executed with ":results none".
> Since it is not the results that are hashed, but the effective
> parameters of the invocation, wouldn't it make more sense to store the
> parameter hash with the source block or call rather than the result?
> That would free up the current place to hash the actual result to
> check if the results have been tampered with.
>
I prefer leaving the hash with the results, as it is the results which
are "hashed". Also, same input does not always guarantee same output,
e.g.,
#+begin_src sh
date
#+end_src
>
>
> Regards,
> Achim.
--
Eric Schulte
http://cs.unm.edu/~eschulte
- [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Aaron Ecay, 2013/03/05
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Aaron Ecay, 2013/03/08
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Achim Gratz, 2013/03/08
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results,
Eric Schulte <=
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Achim Gratz, 2013/03/08
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Eric Schulte, 2013/03/09
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Aaron Ecay, 2013/03/09
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Eric Schulte, 2013/03/09
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Aaron Ecay, 2013/03/12
- Re: [O] [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results, Eric Schulte, 2013/03/13