[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Smart inference of task progress when exporting to TJ3
From: |
Daimrod |
Subject: |
Re: [O] [PATCH] Smart inference of task progress when exporting to TJ3 |
Date: |
Fri, 03 May 2013 10:40:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Martin <address@hidden> writes:
Hello Martin,
Thanks for your patch. I will only make a few stylistic remarks.
1. Could you add `contrib/lisp/ox-taskjuggler.el:' to the subject? (The
first line of the commit message)
2. IIUC you don't need the TINYCHANGE cookie because the changes are
made in contrib/ which doesn't require copyright assignment.
Furthermore, I don't think your changes could be considered `tiny'
(it changes more than 20 lines and doesn't look like a rewrite).
3. Could you reformat a bit your code so it fit in 80 column? (You can
often use M-q for the comments)
--
Daimrod/Greg
pgpeXWqll9Aqi.pgp
Description: PGP signature