Re: [O] [PATCH] org-contacts.el: add expire feature

[Feng Shu]

Karl Voit <address@hidden> writes:

> * Daimrod <address@hidden> wrote:
>>
>> Feng Shu <address@hidden> writes:
>>
>>> * test
>>>   :PROPERTIES:
>>>   :EMAIL: address@hidden  address@hidden  address@hidden
>>>   :PHONE:  123456  123457 123458
>>>   :EXPIRE:  address@hidden 123457
>>>   :END:
>>>
>>> when completing or exporting to vcard,  the emails and  phones in the
>>> expire property (address@hidden and 123457) will be ignore
>
> This is a very good patch, fixing an issue I also do have currently.
>
>> Since the purpose of this property is to ignore some values when
>> exporting to vcard, don't you think it would be better to name it IGNORE
>> or VCARD_IGNORE? (and of course to rename all functions accordingly)
>
> I totally agree.
>

I have changed it to "IGNORE"
> At first, I could not follow Feng Shu's explanation because I
> thought that some (meta-) data gets expired after a certain period
> of time. But then I realized that he meant that these things expired
> in the past.
>
> From the user point of view, I also do think that renaming the
> property from :EXPIRE: to :IGNORE: would be better in terms of
> understanding its purpose and how it works.
>
> (If you do tend to keep the wording, I would at least rename it to
> :EXPIRED: which emphasizes the fact that these things expired in the
> past.)

--