[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] ob-core.el: fix confirm before eval when using a functio
|
From: |
Achim Gratz |
|
Subject: |
Re: [O] [PATCH] ob-core.el: fix confirm before eval when using a function |
|
Date: |
Mon, 01 Jul 2013 22:26:05 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Richard Hansen writes:
> When `org-confirm-babel-evaluate' is a function, this construct:
>
> (or (when (functionp org-confirm-babel-evaluate)
> (funcall org-confirm-babel-evaluate lang block-body))
> org-confirm-babel-evaluate)
>
> will always be true -- if the function evaluates to nil, the `or' will
> evaluate to the value of `org-confirm-babel-evaluate', which is
> non-nil.
Indeed, thanks for catching it. This had actually been fixed before in
exactly the same way, then replaced by a cond form and then replaced
again (wrongly) with an or form… I should have looked at the history of
that code more closely.
Fixed in maint and master.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables