emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [Patch] Few small fixes to html header


From: Bastien
Subject: Re: [O] [Patch] Few small fixes to html header
Date: Wed, 16 Apr 2014 16:50:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

Hi Marcin and Rick,

Marcin Antczak <address@hidden> writes:

>> Another good question. Bastien- Do you think it makes sense to do a
>> whitespace cleanup only commit of ox-html to master?
>
> +1 from me.

The practice I've seen on Emacs is to not do whitespace commits,
but the cleanup whitespace when there is another real change.

Let's do it that way.

>> While source whitespace and output formatting are annoying, our
>> approach to modifications of this (quite old) file has been to not
>> make changes which don't materially affect functionality or fix bugs
>> (the rule of least damage :).
>
> I agree. But code really should be valid and IMHO little improvements
> and code cleanups are ok.

Agreed.  Can you submit a patch for the small enhancement you are
suggesting?  Then you can also do the whitespace cleanup.

Thanks!

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]