emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fix error prone babel table output format detection


From: Ian Kelling
Subject: Re: [O] [PATCH] Fix error prone babel table output format detection
Date: Thu, 01 May 2014 02:32:43 -0700
User-agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux)

Ian Kelling <address@hidden> writes:
> Below is a patch that addresses the 2 previously mentioned
> problems. 

It's a bit late.  here is the same patch with correct indentation.

> -- >8 --
Subject: [PATCH] Fix error prone babel table output format detection

* lisp/ob-core.el: Test that all elements are in a list are lists or
'hline instead of just the first.

org-babel table output uses different formatting for a list of lists,
but detects it incorrectly causing an error. An example of a block
causing an error is an emacs lisp source block containing just 1 line:
'((1) 2)
---
 lisp/ob-core.el |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 1348f04..9eb2c7a 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2184,9 +2184,16 @@ code ---- the results are extracted in the syntax of the 
source
                 ((funcall proper-list-p result)
                  (goto-char beg)
                  (insert (concat (orgtbl-to-orgtbl
-                                  (if (or (eq 'hline (car result))
-                                          (and (listp (car result))
-                                               (listp (cdr (car result)))))
+                                  (if (let ((len (length result))
+                                            (proper t)
+                                            (i 0)
+                                            elem)
+                                        (while (and proper (< i len ))
+                                          (setq elem (nth i result))
+                                          (unless (or (listp elem) (eq elem 
'hline))
+                                            (setq proper nil))
+                                          (setq i (1+ i)))
+                                        proper)
                                       result (list result))
                                   '(:fmt (lambda (cell) (format "%s" cell)))) 
"\n"))
                  (goto-char beg) (when (org-at-table-p) (org-table-align)))
-- 
1.7.10.4



reply via email to

[Prev in Thread] Current Thread [Next in Thread]