emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [RFC] Rewrite indentation functions


From: Eric Abrahamsen
Subject: Re: [O] [RFC] Rewrite indentation functions
Date: Sun, 04 May 2014 11:25:27 +0800
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux)

Nicolas Goaziou <address@hidden> writes:

> Hello,
>
> Eric Abrahamsen <address@hidden> writes:
>
>>> Right now I'm seeing breakage with `org-set-property' -- this only
>>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR
>>> property with that command, value of "asdfadsf", gives me this:
>>>
>>> * Test Heading
>>>   :PROPERTIES:
>>>
>>>   :EXPORT_AUTHOR: asdfasdfnil        nil
>>>
>>> Extra blank nil, spurious "nils", and no :END:
>
> [...]
>
>> Specifically, in this section of `org-indent-line':
>>
>> (when (eq type 'node-property)
>>             (let ((column (current-column)))
>>               (save-excursion
>>                 (beginning-of-line)
>>                 (looking-at org-property-re))
>>               (replace-match (concat (match-string 4)
>>                                      (format org-property-format
>>                                              (match-string 1)
>>                                              (match-string 3)))
>>                              t t)
>>               (org-move-to-column column)))
>>
>> Those match-string calls toward the end both return "nil", and the
>> "nil"s get inserted directly into the buffer. I tried this with a
>> minimal setup (load-paths only, and a blank Org file) and could
>> reproduce.
>
> Indeed. I attach a replacement for both patch 1 and 2.

Looks good! Nothing else to report so far...




reply via email to

[Prev in Thread] Current Thread [Next in Thread]