[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] babel C, C++, D enhancement
From: |
Thierry Banel |
Subject: |
Re: [O] babel C, C++, D enhancement |
Date: |
Sun, 08 Jun 2014 22:19:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Hi Eric, hi All
Here is a new patch (do not apply the previous).
I added a check in the test suite for the D compiler availability
(and for the C++ compiler as well).
It silently returns true when the compiler is not found.
To run the test suite I did that:
- start from an up-to-date org-mode/ GIT directory
- create a GIT branch, checkout there
- apply the patch : git am patch-file
- make clean
- make autoloads
- make test-dirty
Eric, this result you were getting is strange:
FAILED ob-C/inhomogeneous_table
It is as though the NEW test suite was run against the OLD ob-C.el
Maybe there was an old .elc compiled file hanging around ?
Anyway, it works fine for me.
Could someone check and tell me if something goes wrong ?
Have fun
Thierry
Le 06/06/2014 18:31, Eric Schulte a écrit :
> Hi Thierry,
>
> This looks wonderful, however after applying this patch I get the
> following errors when running "make test-dirty".
>
>> 10 unexpected results:
>> FAILED ob-C/inhomogeneous_table
>> FAILED ob-D/inhomogeneous_table
>> FAILED ob-D/integer-var
>> FAILED ob-D/list-list-var
>> FAILED ob-D/list-var
>> FAILED ob-D/simple-program
>> FAILED ob-D/string-var
>> FAILED ob-D/table
>> FAILED ob-D/two-integer-var
>> FAILED ob-D/vector-var
> Could you update the test suite so that the C tests pass, and the D
> tests are not executed when D is not available?
>
> Also, could you flesh out the commit message so that it meets the Emacs
> commit message guidelines (http://orgmode.org/worg/org-contribute.html)?
>
> Many Thanks,
> Eric
>
>
0001-Babel-C-C-D-support-for-non-homogeneous-input-tables.patch
Description: Text Data
- Re: [O] Patch for testing `org-open-at-point', Bastien, 2014/06/01
- Re: [O] Patch for testing `org-open-at-point', Achim Gratz, 2014/06/01
- Re: [O] Patch for testing `org-open-at-point', Bastien, 2014/06/01
- [O] babel C, C++, D enhancement, Thierry Banel, 2014/06/01
- Re: [O] babel C, C++, D enhancement, Eric Schulte, 2014/06/06
- Re: [O] babel C, C++, D enhancement, Thierry Banel, 2014/06/07
- Re: [O] babel C, C++, D enhancement,
Thierry Banel <=
- Re: [O] babel C, C++, D enhancement, Eric Schulte, 2014/06/08
- Re: [O] babel C, C++, D enhancement, Thierry Banel, 2014/06/09
- Re: [O] babel C, C++, D enhancement, Achim Gratz, 2014/06/13
- Re: [O] babel C, C++, D enhancement, Eric Schulte, 2014/06/13
- Re: [O] babel C, C++, D enhancement, Thierry Banel, 2014/06/13
- Re: [O] babel C, C++, D enhancement, Achim Gratz, 2014/06/16
- Re: [O] babel C, C++, D enhancement, Thierry Banel, 2014/06/16
- Re: [O] babel C, C++, D enhancement, Thomas S. Dye, 2014/06/16
- Re: [O] babel C, C++, D enhancement, Nick Dokos, 2014/06/16
- Re: [O] babel C, C++, D enhancement, Achim Gratz, 2014/06/17