Re: [O] patch: Oracle engine for SQL blocks

[Eric Schulte]

"John Dell'Aquila" <address@hidden> writes:

> Thanks, Eric. I've started the FSF assignment process.
>
> I have a question about the header row delimiter in the results table. I
> didn't set the header-delim variable in the code, becasue the user can
> change the Oracle underline character, possibly multiple times, so it is
> difficult to work out a proper setting.
>
> The results appeared OK with header-delim left at "". I now realize that
> this causes the table to be mis-parsed when the first column is blank,
> even though it has a proper header.
>
> I put in a fix to scan for the first "set underline" command and use
> that character, otherwise set header-delim to "-". In the process of
> testing I found I could always set header-delim to '-' and the table
> parsed correctly even when the actual Oracle delimiter was set
> differently.
>
> I'm wondering how this is supposed to work. I'd rather not add
> unecessary complexity, but I don't want on rely on a bug or misfeature
> either.
>

I'm not familiar with this portion of ob-sql, so I'll defer to your best
judgment.

Best,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D (see https://u.fsf.org/yw)