[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] -for review- Tangling with variable transfer of variable
From: |
Rainer M Krug |
Subject: |
Re: [O] [PATCH] -for review- Tangling with variable transfer of variables |
Date: |
Mon, 23 Jun 2014 12:45:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (darwin) |
"Charles C. Berry" <address@hidden> writes:
V> On Fri, 20 Jun 2014, Rainer M Krug wrote:
>
>> Attached please find =the reworked patch.
>>
>> 1) uses local() and closes connection
>> 2) does not leave a variable cal;led file behind
>>
>
> Seems to work on a few test cases.
>
> I'd move the strings to defconsts.
>
> Putting a newline before each `%S' will outdent the first line of
> :var value when it is echoed in the session log so it will be easier to
> view.
>
> ===
>
> With Eric's input on this:
>
> Would you also change this at the end of org-babel-R-assign-elisp:
>
> res})" name file header row-names max))))
> - (format "%s <- %s" name (org-babel-R-quote-tsv-field value))))
> + (format "%s <- %S" name
> + (if (stringp value) value (prin1-to-string value)))))
>
> ??
>
> I think this is innocuous for plain strings with no internal quotes, but
> allows almost anything to be passed to R as a string.
>
> So
> :var x=[1 2 3 "4" 5]
>
> will be passed to R as x <- "[1 2 3 \"4\" 5]"
>
> instead of x <- "[1 2 3 "4" 5] which throws an error.
>
> And this just works:
>
> #+NAME: latex-capt
> #+BEGIN_SRC latex
> \begin{math}
> y = X\beta,
> \mbox{where } \beta = %beta%
> \end{math}
> #+END_SRC
>
> #+BEGIN_SRC R :var ytxt=latex-capt :results raw :wrap latex
> beta <- 1.234
> sub("%beta%",beta,ytxt)
> #+END_SRC
OK - attached please find two patches:
0001-lisp-ob-R.el-Fix-tangling-with-tables.patch
0002-Make-transfer-of-values-from-R-type-aware.patch
The first one fixes tangling with tables including discussed
suggestions, the second one moves the definition of the R code into
defconst and introduces type awareness for the transfer of *values*, but
not tables. I reworked your suggestion and now integer are transferred
to R as integers (L) and float as double.
This already worked for tables.
Could you please check the second patch? In my checks everything worked
as expected.
Cheers,
Rainer
>
>
> HTH,
>
> Chuck
--
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology,
UCT), Dipl. Phys. (Germany)
Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa
Tel : +33 - (0)9 53 10 27 44
Cell: +33 - (0)6 85 62 59 98
Fax : +33 - (0)9 58 10 27 44
Fax (D): +49 - (0)3 21 21 25 22 44
email: address@hidden
Skype: RMkrug
PGP: 0x0F52F982
0001-lisp-ob-R.el-Fix-tangling-with-tables.patch
Description: Text Data
0002-Make-transfer-of-values-from-R-type-aware.patch
Description: Text Data
pgp3zaa6dyfuw.pgp
Description: PGP signature
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, (continued)
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Charles Berry, 2014/06/19
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/20
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/20
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Charles C. Berry, 2014/06/21
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Aaron Ecay, 2014/06/21
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/23
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/23
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/23
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Charles C. Berry, 2014/06/23
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/24
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables,
Rainer M Krug <=
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Charles C. Berry, 2014/06/23
- Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/24
Re: [O] [PATCH] -for review- Tangling with variable transfer of variables, Rainer M Krug, 2014/06/20