Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

[Steven Rémot]

Le 09/08/2014 02:38, Thomas S. Dye a écrit :
> Aloha Steven,
>
> Steven Rémot <address@hidden> writes:
>
> > Hi,
> >
> > I did some changes to support :dbname, :dbhost and :database in SQL
> > code blocks when using postgresql engine.
> >
> > Even if it was possible to specify this information using :cmdline
> > parameter, I thought it was a bit cleaner to be able to provide this
> > information in a way independent from the command line.
> >
> > I will gladly accept any remark / comment on this patch.
> >
> > Regards,
> > Steven Rémot
> I'm not certain who is maintaining ob-sql.el, so I'm not replying in any
> directly useful way.  However, this patch looks straightforward and
> good to me.
>
> Have you signed FSF papers?  If so, the maintainer can accept (or
> reject) your patch.  If not, then you'll need to identify it as a tiny
> change (see http://orgmode.org/worg/org-contribute.html).
>
> Thanks for this contribution to Org mode.
>
> All the best,
> Tom
This is my only contribution to Emacs code, and it changes only 12 lines 
that impact a very tiny fragment of org, so I though I could send it 
without signing papers. If I was wrong, I don't mind signing papers at all.

Regards,
Steven Rémot