[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Bug (regression) in org-replace-disputed-keys. Bisected.
From: |
Miro Bezjak |
Subject: |
Re: [O] Bug (regression) in org-replace-disputed-keys. Bisected. |
Date: |
Fri, 14 Nov 2014 23:29:43 +0100 |
Hi all,
I rather like that `org-read-date` takes over windmove keys during the
second or two that I'm using it. By reverting this, I guess I'll have
to copy and paste the whole `defvar` just to add
`(org-replace-disputed-keys nil)`.
May I make a compromise here? Can we make a new defcustom
(org-disable-disputed-keys-during-read-date?) that will disable
`org-replace-disputed-keys` when setting up
`org-read-date-minibuffer-local-map`?
Regards,
Miro
On Mon, Nov 3, 2014 at 9:54 PM, Nicolas Goaziou <address@hidden> wrote:
> Hello,
>
> Teika Kazura <address@hidden> writes:
>
>> Now a real fix. There're two candidates:
>>
>> (i) Revert the wrong commit. Since it was in fact done in two separate
>> commits[2], you need another patch, not git-revert. Here it is:
>> ------------------------------------------------------------------------
>> diff -u -r org-8.2.7c-orig/lisp/org.el org-8.2.7c/lisp/org.el
>> --- org-8.2.7c-orig/lisp/org.el 2014-09-30 18:10:54.485977061 +0900
>> +++ org-8.2.7c/lisp/org.el 2014-09-30 18:11:24.293602328 +0900
>> @@ -16220,8 +16220,7 @@
>> (defvar org-read-date-inactive)
>>
>> (defvar org-read-date-minibuffer-local-map
>> - (let* ((org-replace-disputed-keys nil)
>> - (map (make-sparse-keymap)))
>> + (let* ((map (make-sparse-keymap)))
>> (set-keymap-parent map minibuffer-local-map)
>> (org-defkey map (kbd ".")
>> (lambda () (interactive)
>> ------------------------------------------------------------------------
>
> I think this change is appropriate. Could you provide a patch with git
> format-patch?
>
>
> Regards,
>
> --
> Nicolas Goaziou