|
From: | Charles C. Berry |
Subject: | Re: [O] [PATCH]: BUG fix and Add header-args property to source block info |
Date: | Thu, 12 Feb 2015 10:27:43 -0800 |
User-agent: | Alpine 2.00 (OSX 1167 2008-08-23) |
On Thu, 12 Feb 2015, Rainer M Krug wrote:
Rainer M Krug <address@hidden> writes:Nicolas Goaziou <address@hidden> writes:Hello, Rainer M Krug <address@hidden> writes:Please find attached the below described patch including the fix for the error reported - function raises error when property value is numeric.Looks good. Thank you.Thanks.Could you provide an appropriate commit message?Here is the patch attached with the commit message - hope it is OK.Bonus points if you also add a test.I think I will skip the bonus points this time - sorry. I would be very grateful if you could submit the patch without a test. Cheers, RainerAre there some guidelines on how to write tests? Never done this before...
Alan's suggestions are good. To which I might add browse `testing/README'. Try this. Evaluate these blocks: #+BEGIN_SRC emacs-lisp :var here=(buffer-file-name) (add-to-list 'load-path (file-name-directory here)) (require 'org-test) #+END_SRC #+BEGIN_SRC emacs-lisp (ert-deftest test-org-babel/view-src-block-info-for-identity () "Check `(identity #o444)' in header-args property." (org-test-with-temp-text "#+PROPERTY: header-args :tangle-mode (identity #o444) ,#+begin_src emacs-lisp (+ 1 2) ,#+end_src" (org-mode-restart) (forward-line 2) (org-babel-view-src-block-info))) #+END_SRC Then do ` M-x ert RET t RET' and a window should pop up showing that you either passed (with your patch) or failed (without your patch) 1 test. If that much works, then submit a patch for testing/lisp/test-ob.el. HTH, Chuck
[Prev in Thread] | Current Thread | [Next in Thread] |