Re: [O] [patch, ox-latex] better hyperref and title options

[Nicolas Goaziou]

Rasmus <address@hidden> writes:

> So irrespective of this, here's an updated patch that uses
> secondary-string parsing.  Should I add it to master before or after I get
> done with this moving description and keywords?

You can go ahead, after fixing some minor typos. Thanks.

> * ox-latex.el (org-latex-format-spec): New function with format-specs.

Typo in the name.

>   (org-latex-template): Use org-latex-format-spec.
>   (org-latex-hyperref-template): New defaults and use
>   org-latex-format-spec.
>   (org-latex-title-command): Use org-latex-format-spec.

Ditto (x3).

> +*** ~org-latex-hyperref-template~, ~org-latex-title-command~ formatting
> +New formatting keys are supported.  See ~org-latex-format-spec~.

See docstrings for more information (no need to talk about
`org-latex--format-spec').

> +(defun org-latex--format-spec (info)
> +  "Create a format-spec for e.g. `org-latex-hyperref-template'.
> +Also used by `org-latex-title-command'

  "Create a format-spec for document meta-data.
  INFO is.."

is enough IMO.

> -  (let ((title (org-export-data (plist-get info :title) info)))
> +  (let ((title (org-export-data (plist-get info :title) info))
> +     (spec (when (org-some 'stringp (list org-latex-hyperref-template
> +                                          org-latex-title-command))
> +             (org-latex--format-spec info))))

Nitpick: #'stringp

Anyway, both `org-latex-hyperref-template' and `org-latex-title-command'
are always strings, per defcustom type. So you can drop the `when' part:

  (spec (org-latex--format-spec info))


Regards,