emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fix massive slowdown in org-id-find


From: Florian Beck
Subject: Re: [O] [PATCH] Fix massive slowdown in org-id-find
Date: Tue, 24 Mar 2015 12:05:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> Would you mind elaborating a bit? Slow down doing what? In which cases?

A fraction of a second vs 10 seconds when executing a function that
calls org-id-find. The slowdowwn is not quite as massive since I
cleaned up org-id-files a bit, however.

> Could you profile it?

I'll look into it.

> Here, it catches false positives, e.g., lines looking like properties in
> example blocks. It also overlooks accumulated values.

This is true. However that is not really relevant for id searches, is
it? In the worst case, you'll find ids in example, etc blocks when you
SEARCH for them.

I guess, you want to use org-find-property in other places as well. In
that case org-id-find could maybe use a faster, simplified version? Let
me see, if I can do some profiling tonight.

> It should fail with "make test".

Doesn't work for me (it hangs).

-- 
Florian Beck




reply via email to

[Prev in Thread] Current Thread [Next in Thread]