emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Avoiding `intangible'


From: Rasmus
Subject: Re: [O] Avoiding `intangible'
Date: Thu, 16 Apr 2015 11:50:31 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Hi Stefan,

Thanks for the patch.

Stefan Monnier <address@hidden> writes:

> I'm on a crusade to eradicate the `intangible' property, which happens
> to rub me the wrong way because it's implemented at too-low a level (it
> affects every point movement) which incurs a significant performance
> penalty (even when not used) and affects a lot of code which then
> needs to be fixed by binding inhibit-point-motion-hooks (which I'm
> considering defaulting to t).

OK.  In addition to the places you've identified, it's also mentioned
here:

./contrib/lisp/org-colview-xemacs.el:396:     (overlay-put ov 'intangible t)
./contrib/lisp/org-eval.el:154:  (list 'display value 'intangible t 
'font-lock-multiline t
./lisp/org.el:11165:    (unless (get-text-property (match-end group) 
'intangible) ; Emacs 21


> So I'd like to install the patch below.  Any objection?  The `invisible'
> property already ensures that the command loop moves point away from
> those overlays, so the `intangible' property should not be needed there
> (tho I don't use Org enough to know how to test it).

I can't even make the first modified function do what it is documented to
do.  From the special text properties documentation and the documentation
of the changed I don't see a reason why it would not be OK.

I'll install it in master and it will eventually get back to Emacs-core
once 8.3 released assuming no unforeseen breakages are associated with the
change.

Thanks,
Rasmus

-- 
Not everything that goes around comes back around, you know




reply via email to

[Prev in Thread] Current Thread [Next in Thread]