Re: [O] Bug: Priority #B in Agenda causes invalid face reference [8.2.1 (8.2.1-15-ge5cecc-elpa @ /Users/Paul/.emacs.d/elpa/org-20131021/)]

[Nicolas Goaziou]

Renato Ferreira <address@hidden> writes:

> Yes you are right, i digged deeper in the problem and it seems to be
> that the cond:
>
> (cond ((org-face-from-face-or-color
>                      'priority nil
>                      (cdr (assoc p org-priority-faces))))
>                    ((and (listp org-agenda-fontify-priorities)
>                          (org-face-from-face-or-color
>                           'priority nil
>                           (cdr (assoc p org-agenda-fontify-priorities)))))
>                    ((equal p l) 'italic)
>                    ((equal p h) 'bold))
>
> returns nil altogether for priorities which are neither the highest
> (equal p h) or the lowest (equal p l) (hence the bug appearing on #B
> priorities by default).
>
> That gives (nil . org-priority) so:
> (overlay-put ov 'face (nil . 'org-priority))
>
> Which triggers the message the second time it runs.

Indeed.

> From the elisp manual for (overlay-put ... 'face (a-cons . cell)):
>
> • A cons cell of the form ‘(foreground-color . COLOR-NAME)’ or
> ‘(background-color . COLOR-NAME)’.  This specifies the
> foreground or background color, similar to ‘(:foreground
> COLOR-NAME)’ or ‘(:background COLOR-NAME)’.  This form is
> osupported for backward compatibility only, and should be
> avoided.

Actually, the function uses the second point:

  • A list of faces.  Each list element should be either a face
    name or an anonymous face.  This specifies a face which is an
    aggregate of the attributes of each of the listed faces.
    Faces occurring earlier in the list have higher priority.

It should be fixed in c763faf529ef2e8f257a27df29531a4f77d633f5. Thank
you for reporting it.


Regards,