emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] commit 4e864643 breaks org-return


From: Stefan-W. Hahn
Subject: Re: [O] commit 4e864643 breaks org-return
Date: Sat, 24 Oct 2015 08:48:47 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Mail von Nicolas Goaziou, Sat, 24 Oct 2015 at 00:34:54 +0200:

Hello,

> >> commit 4e864643bdb6bba3e000ea51fb746a26e40b1f77
> >> Author: Nicolas Goaziou <address@hidden>
> >> Date:   Sun Oct 18 09:36:15 2015 +0200
> >> 
> >> changes the behaviour of org-return when positioned right after a link with
> >> org-return-follows-link set to t.
> >
> > the following patch seems to repair the behaviour:
> 
> But is the current behaviour broken in the first place? At least it is
> consistent with `org-open-at-point' (C-c C-o).

Yes. Yes.

Before commit 4e86464 the behaviour was:

[[link][description]]x

with cursor at x hitting <RET> I got a line opened with cursor positioned
at the beginning of the new line (or indented).

But you are right, org-open-at-point with cursor at position x jumps
to the link. This behaviour is not changed with the commit but I think
this is also not the right behaviour. If you go with the mouse over the x
then you don't get any popup from the link. For this you have to
go at least over the last character "]" of the link resp. the visual "n"
of the description. Even if you describe-text-properties with cursor at x
you don't get any hint of the link. You have to go over the "]" (resp. "n")
to see the link hint.

From my point of view the commit 4e86464 changes the behaviour of org-return
in a manner of which I think is not natural. org-open-at-point is, in my
opinion, wrong in the same way because description says:
"... When point is on a link, follow it."
And being with cursor at x is obviously not "on a link".

Any opinions from you or other org'ers?

With kind regards,
Stefan

-- 
Stefan-W. Hahn                          It is easy to make things.
                                        It is hard to make things simple.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]