Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed.

[Rasmus]

Hi Puneeth,

First, I now think your suggestion (to widen) is consistent with the
current behavior of Org.  E.g. C-c C-o on a CUSTOM_IDs link will widen the
buffer.  Also, if ID is outside of the current file, it will follow the
link.  Second, I think the current behavior should be changed, but that is
a separate discussion.

Thus, I think for now your suggestion is the correct one.

However, you need to make sure that it only widens if ID is in the same
buffer and outside of the narrow.  In particular, when ID is in another
file you shouldn’t widen.  When it’s within the scope of the narrow it
shouldn’t widen.  This ALREADY seems to be the case.

However, your patch doesn’t work for me in the following example, starting
from emacs -q, adding /tmp/test.org (with the below content) to my agenda
list and requiring org-id, org-narrow-to-subtree on foo, and then
org-open-at-point on the link

    * foo
    [[id:myid]]  now C-c C-o on link

    * bar
    :PROPERTIES:
    :ID:       myid
    :END:

We can add your patch when it works properly.

> I find it weird to have a subtly different thing happening depending
> on whether or not the target buffer is narrowed -- entry shown in
> normal buffer when no narrowing vs. entry shown in a special/indirect
> buffer.

Widening is the current behavior when you click on a most link in a
narrowed buffer.  Personally, I would rather throw an error.

> Also, given that no other part of org really uses indirect buffers, I
> don't know if this function alone should make use of that feature.

Another option might be to make "C-c &" recall the last narrow (as John
also mentions).  But this is sort of redefining the meaning of C-c &,
which may not be comfortable.

> PS: I've patched my org sources to do indirect buffers for this, and
> will try it out for sometime to see how it feels.

Thanks a lot for your efforts, Puneeth.

Cheers,
Rasmus

-- 
Together we will make the possible totalllly impossible!