[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to mas
From: |
Jan Malakhovski |
Subject: |
Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint |
Date: |
Wed, 28 Oct 2015 10:34:22 +0000 |
User-agent: |
Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.2 (x86_64-unknown-linux-gnu) |
Jan Malakhovski <address@hidden> writes:
> Nicolas Goaziou <address@hidden> writes:
>
>> Could you provide an ECM with appropriate CLOCK lines?
>
> Attached.
Okay, so I bisected and found that the offender is
9f5e698679aecbed872a2030e4157e5e2b1d87e0. Since then these lines have
changed, so the following
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index bdb69c5..38baac2 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8411,10 +8411,10 @@ When called with a prefix argument, include all archive
files as well."
(org-flag-heading nil))) ; show the next heading
(when (outline-invisible-p)
(outline-show-entry)) ; display invisible text
- (recenter (/ (window-height) 2))
- (org-back-to-heading t)
- (if (re-search-forward org-complex-heading-regexp nil t)
- (goto-char (match-beginning 4))))
+ (recenter (/ (window-height) 2)))
+; (org-back-to-heading t)
+; (if (re-search-forward org-complex-heading-regexp nil t)
+; (goto-char (match-beginning 4))))
(run-hooks 'org-agenda-after-show-hook)
(and highlight (org-highlight (point-at-bol) (point-at-eol)))))
makes all of my problems this go away.
If you read 9f5e698679aecbed872a2030e4157e5e2b1d87e0 you'll notice that
it changed both the behavior and the doc-string (that is to say that you
can't refer to doc-string as an argument against the previous behavior).
I'm pretty sure that there are other org-mode users that are weeping
silently since that change. Suppose you have more than a screen of clock
lines in LOGBOOK under a heading (I have headings that have thousands).
(org-agenda-goto) before 9f5e698679aecbed872a2030e4157e5e2b1d87e0 is
very helpful when moving CLOCK lines between headings (think "refile
CLOCK line") or editing overlaps or gaps: you <Tab> or click on the
heading and here you are at the CLOCK, but after
9f5e698679aecbed872a2030e4157e5e2b1d87e0 you have to *retype* the date
and time into search, which is annoying to say the least.
I'm willing to listen, but I seriously doubt there's such a compelling
argument defending the change. Even when out of `org-agenda-list` in
plain `org-agenda`, jumping to SCHEDULED or DEADLINE lines is nicer than
to the heading itself.
Cheers,
Jan
- [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Jan Malakhovski, 2015/10/25
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Nicolas Goaziou, 2015/10/25
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Jan Malakhovski, 2015/10/25
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Nicolas Goaziou, 2015/10/25
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Jan Malakhovski, 2015/10/25
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint,
Jan Malakhovski <=
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Nicolas Goaziou, 2015/10/28
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Matt Lundin, 2015/10/28
- Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint, Jan Malakhovski, 2015/10/28