[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 7/8] ox-taskjuggler.el: allow 'priority' to be a directly
From: |
Kosyrev Serge |
Subject: |
Re: [O] [PATCH 7/8] ox-taskjuggler.el: allow 'priority' to be a directly-specified integer |
Date: |
Tue, 10 Nov 2015 11:26:05 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Aaron Ecay <address@hidden> writes:
> 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>>
>> * ox-taskjuggler.el (org-taskjuggler--build-task): fix priority
>> specification
>> by allowing it to be directly passed down, in case it parses as an integer.
>> ---
>> contrib/lisp/ox-taskjuggler.el | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
>> index 44ffeb6..d49db62 100644
>> --- a/contrib/lisp/ox-taskjuggler.el
>> +++ b/contrib/lisp/ox-taskjuggler.el
>> @@ -875,10 +875,16 @@ a unique id will be associated to it."
>> (org-taskjuggler-get-end task))
>> (org-element-property :PERIOD task)))))
>> (priority
>> - (let ((pri (org-element-property :priority task)))
>> + (let ((pri (org-element-property :PRIORITY task)))
>> (and pri
>> - (max 1 (/ (* 1000 (- org-lowest-priority pri))
>> - (- org-lowest-priority
>> org-highest-priority)))))))
>> + ;; The exported task priority can be either specified
>> + ;; via the Org priority mechahism (which is currently
>> broken),
>
> Can you say more about what breakage you mean? Is it something that can
> be easily fixed?
Perhaps I was unclear in this message -- it's not the Org's priority
mechanism that is broken, it's the way ox-taskjuggler uses it that is.
Org specifies priorities via a list of enums, whereas TJ expects an
integer in the range 0-1000.
The quoted little piece of math in ox-taskjuggler tried to provide a
mapping, but failed and I couldn't figure out how to make it work --
mainly because I couldn't understand how it was /supposed/ to work.
Hence I made a shortcut.
--
с уважениeм / respectfully,
Косырев Сергей