Re: [O] ox-html, top-row-p

[Fabrice Popineau]

Hi,

So the problem is due to lexical binding (I am using emacs 25 devel branch).

The following variables can't be dynamically bound anymore in ox-html:

row-number, rowgroup-number, start-rowgroup-p, end-rowgroup-p, top-row-p, bottom-row-p .

There are 2 options :

- declare them with defvar

- pass them to eval as an environment.

Here is a patch for the second option, but I wonder if the first one wouldn't be better.

diff --git a/vendor/org-mode/lisp/ox-html.el b/vendor/org-mode/lisp/ox-html.el

index 6affac4..4e56ab3 100644

--- a/vendor/org-mode/lisp/ox-html.el

+++ b/vendor/org-mode/lisp/ox-html.el

@@ -3336,10 +3336,22 @@ communication channel."

        ;; Begin a rowgroup?

        (when start-rowgroup-p (car rowgroup-tags))

        ;; Actual table row.

-       (concat "\n" (eval (car (plist-get info :html-table-row-tags)) t)

+       (concat "\n" (eval (car (plist-get info :html-table-row-tags))

+                         `((row-number . ,row-number)

+                           (rowgroup-number . ,rowgroup-number)

+                           (start-rowgroup-p . ,start-rowgroup-p)

+                           (end-rowgroup-p . , end-rowgroup-p)

+                           (top-row-p . ,top-row-p)

+                           (bottom-row-p . ,bottom-row-p)))

               contents

               "\n"

-              (eval (cdr (plist-get info :html-table-row-tags)) t))

+              (eval (cdr (plist-get info :html-table-row-tags))

+                    `((row-number . ,row-number)

+                      (rowgroup-number . ,rowgroup-number)

+                      (start-rowgroup-p . ,start-rowgroup-p)

+                      (end-rowgroup-p . , end-rowgroup-p)

+                      (top-row-p . ,top-row-p)

+                      (bottom-row-p . ,bottom-row-p))))

        ;; End a rowgroup?

        (when end-rowgroup-p (cdr rowgroup-tags))))))

Best regards,

Fabrice

2015-12-13 0:36 GMT+01:00 Fabrice Popineau <address@hidden>:

Hi,

I get an error in ox-html.el with the latest org-mode when exporting tables to html :

Debugger entered--Lisp error: (void-variable top-row-p)

  (cond (top-row-p "<tr class=\"tr-top\">") (bottom-row-p "<tr class=\"tr-bottom\">") (t (if (= (mod row-number 2) 1) "<tr class=\"tr-odd\">" "<tr class=\"tr-even\">")))

  eval((cond (top-row-p "<tr class=\"tr-top\">") (bottom-row-p "<tr class=\"tr-bottom\">") (t (if (= (mod row-number 2) 1) "<tr class=\"tr-odd\">" "<tr class=\"tr-even\">"))) t)

  org-html-table-row((table-row (:type standard :begin 1784 :end 1898 :contents-begin 1785 :contents-end 1897 :post-blank 0 :post-affiliated 1784 :parent ...))

Can anybody confirm or is something wrong on my side ?

Greetings,

Fabrice