[O] Bug: repeaters on TODOs with notes that contain org-formatted dates causes SCHEDULE line to disappear upon org-todo from commit 481719fbd5751aaa9c672b762cb43aea8ee986b0 onward [8.3.2 (release_8.3.2-203-g481719 @ /path/to/org/mode/upstream/checkout/)]

[Bradley M. Kuhn]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
Repeaters on TODOs with notes that contain org-formatted dates causes
SCHEDULE line to disappear upon org-todo from commit
481719fbd5751aaa9c672b762cb43aea8ee986b0 onward.

Using the attached test.org file, one can reproduce this bug this way:

$ cd /path/to/org/mode/upstream/checkout
$ git checkout 481719fbd5751aaa9c672b762cb43aea8ee986b0
$ make clean; make
$ emacs --no-init

In *scratch* buffer:

 (add-to-list 'load-path "/path/to/org/mode/upstream/checkout")
 (load-library "org")

C-x C-f test.org <RET>

C-t d

What that yields is the file I attached as 'test-481719-after-ctrl-t-d.org'.
As you can see, the entire SCHEDULED line has disappeared.

What I expected was 'test-correct-after-ctrl-t-d.org', which I get if I
switch the "git checkout" line above to checkout the previous revision
in the master branch, which is a709aed145e2e95db60835495126f351828e27dd.

While trying to build up this test example to report the bug, I
discovered that the existence of "<2015-03-31 Tue>" in the org states
are what causes the problem.  If you remove the < and > from that line,
you get the expected results.

I don't believe it's a invalid org-mode format to have a date like that
floating around in your org-done-notes, and as such I believe this is a
bug.

The problem persists through to current master HEAD; it has not been
fixed AFAICT in subsequent commits.  In fact, the problem is "even
worse" when you 'git checkout master' above; you get:
   Error in post-command-hook (org-add-log-note): (error "Before first headline 
at position 1 in buffer test.org")

And the new "State" line is inserted ABOVE the TODO.  See the attached
'test-master-after-ctrl-t-d.org" for that.


Emacs  : GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5)
 of 2015-03-07 on trouble, modified by Debian
Package: Org-mode version 8.3.3 (release_8.3.3-423-g5964b7 @ 
/path/to/org/mode/upstream/checkout/)

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe
                      org-babel-hide-result-toggle-maybe
                      org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
                          org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
                     org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook org-show-block-all
                    append local]
                   5]
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook
                    org-babel-show-result-all append local]
                   5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
                          org-babel-execute-safely-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
                  org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )

** TODO Testing
   SCHEDULED: <2016-02-04 Thu 06:30 ++1m>
   :PROPERTIES:
   :LAST_REPEAT: [2016-01-10 Sun 12:15]
   :END:
   - State "DONE"       from "TODO"       [2015-05-04 Mon 10:54] \\
     I took care of this through <2015-03-31 Tue>; later dates aren't done.

** TODO Testing
   :PROPERTIES:
   :LAST_REPEAT: [2016-01-10 Sun 12:18]
   :END:
   - State "DONE"       from "TODO"       [2016-01-10 Sun 12:18]
   - State "DONE"       from "TODO"       [2015-05-04 Mon 10:54] \\
     I took care of this through <2015-03-31 Tue>; later dates aren't done.

- State "DONE"       from "TODO"       [2016-01-10 Sun 12:30]
** TODO Testing
   :PROPERTIES:
   :LAST_REPEAT: [2016-01-10 Sun 12:30]
   :END:
   - State "DONE"       from "TODO"       [2015-05-04 Mon 10:54] \\
     I took care of this through <2015-03-31 Tue>; later dates aren't done.

-- 
   -- bkuhn
========================================================================
Become a Conservancy Supporter today: https://sfconservancy.org/supporter