Re: [O] Fwd: [PATCH] Add support for ordered list to ox-confluence.el

[Lungang Fang]

Hi Charles and Nicholas,

My code also supports nested mixed lists but is simpler. I mean, my code will convert the list given by Charles to

# Here

-- is

-- an

# example

-- of

-- a

# mixed

# list

Although this format is not mentioned in confluence wiki, it is supported by conflucence according to my test (in Jira).

So, in my opinion, it is a matter of personal preference: more complicated code complies with documented interface, or simpler code that exploits undocumented feature.

I prefer my code. But you guys feel free to make decision. I am OK with whatever you choose.

Cheers,

Lungang

On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst <address@hidden> wrote:

They do conflict.  My version is slightly more complicated since it
also supports nested mixed lists.

For example:

1. Here
   * is
   * an
2. example
   * of
   * a
3. mixed
4. list

Which translates to:

# Here
#- is
#- an
# example
#- of
#- a
# mixed
# list

Which is effectively the same as the example in the Confluence documentation:
https://confluence.atlassian.com/confcloud/confluence-wiki-markup-724765099.html#ConfluenceWikiMarkup-Mixedlists

--
Charles Durst
address@hidden


On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou <address@hidden> wrote:

> Hello,
>
> Lungang Fang <address@hidden> writes:
>
>> Attached is a patch for contrib/lisp/ox-confluence.el generated following
>> instructions on http://orgmode.org/worg/org-contribute.html#patches . It
>> adds support for ordered list.
>
> Thank you.
>
> However, this somewhat conflicts with a patch recently sent on the ML,
> but not yet applied, by Charles Durst (Cc'ed).
>
> Could one double-check if one doesn't supersede the other, or if they
> could be merged (although I suspect the former) and report back so
> I know what patch to apply?
>
> Regards,
>
> --
> Nicolas Goaziou