[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Have SRC_BLOCK :padline accept numbers
From: |
Nicolas Goaziou |
Subject: |
Re: [O] Have SRC_BLOCK :padline accept numbers |
Date: |
Thu, 30 Mar 2017 09:50:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello,
Daniel P Gomez <address@hidden> writes:
> I've amended the commit including the changes you've mentioned.
Thank you.
> I did not change the following, though:
>
> (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines)
>
> because that changed the behaviour of org-babel-tangle. Having a
> string-match-p as a
> match condition broke the default of adding no padlines in the
> first tangled SRC block (when passed with no arguments).
I don't understand this. `string-to-int' and `string-match-p' both have
the same requirements about parameters type, don't they?
> I also noticed that adding this functionality to ob-tangle breaks eldoc
> for me. I guess all org babel header arguments have to be strings?
Probably.
Regards,
--
Nicolas Goaziou