emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of


From: Mario Martelli
Subject: Re: [O] [PATCH] org-protocol: fixes open-source and extends rewriting of URLs
Date: Sun, 25 Jun 2017 10:21:36 +0200

> If all tests in "test-org-protocol.el" pass with your changes, I think
> it is fine to apply them.


        Selector: "test-org-protocol/"
        Passed:  2
        Failed:  0
        Skipped: 0
        Total:   2/2

> Another round of tests for the cases you solve
> would be nice, too.

I added the configuration part. That will be parsed during the tests I suppose.


        Selector: "test-org-protocol/"
        Passed:  3
        Failed:  0
        Skipped: 0
        Total:   3/3

Attachment: 0004-config-for-date-style-URL-is-added-to-org-protocol-t.patch
Description: Binary data


Adding full test-coverage of my changes is beyond my abilities at the moment, I 
must admit.
But I will come back to it soon, I promise ;)
Especially as there are succeeding tests for open-source using old-style URIs. 
(old-style URIs are not working for me with open-source)
That will be the next task for me after completing the documentation.

Speaking of the documentation: is it right, that there is no more support for 
“remember”? 
I would then remove that part from the documentation.

Kind regards
Mario
— 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]