Re: [O] [PATCH] Refactor org-set-tags arguments for clarity

[Kaushal Modi]

On Thu, Jul 13, 2017 at 8:32 AM Nicolas Goaziou <address@hidden> wrote:

Kaushal Modi <address@hidden> writes:

> Correct. I was just extrapolating based on that, that people could be
> making similar uses in their configs and packages.
>
> A search like this (
> https://github.com/search?utf8=%E2%9C%93&q=%22org-set-tags+nil%22+language%3A%22Emacs+Lisp%22&type=Code
> )
> shows that (org-set-tags nil t) is pretty viral in one org-settings.el out
> there.

Then what about something like this

  (defun org-set-tags (&optional align-all align-current)
    "...
  ...
  ALIGN-CURRENT is obsolete and should not be used. When non-nil,
  set ALIGN-ALL to `current'."
    (let ((align-all (if (null align-current) align-all
                       (warn "Deprecated call to `org-set-tags', which see")
                       'current)))
     ...))

That will work. Good idea!

I'll first patch maint, and then this in master. 

--

Kaushal Modi