emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fix ox-md remote image links export


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Fix ox-md remote image links export
Date: Sun, 06 Aug 2017 09:15:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hello,

Jay Kamat <address@hidden> writes:

> I discovered a bug in the ox-md exporter and have created a patch to fix it:
>
> Previously, this image link:
> [[https://git-scm.com/images/address@hidden
>
> would export to:
> ![img](//git-scm.com/images/address@hidden)
>
> which is an invalid markdown image, and won't display properly in
> browsers and other places.
>
> A workaround (which I have been using extremely heavily), is:
> [[file:https://git-scm.com/images/address@hidden
>
> which exports to
> ![img](https://git-scm.com/images/address@hidden)
>
> Which is the proper (unbroken) image link.
>
> I have attached a patch which fixes the first example, so it exports
> the same link as the workaround (and is no longer broken).

Thank you for the report and the patch. I have committed a slightly
different change. Does it solve your issue?

> My papers are currently being processed, but I thought I would post
> this patch early to get feedback, since ideally I would like this bug
> to be fixed as soon as possible :). Hopefully they'll be done before
> the review is completed.

Great! Let me know when the process is done.

Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]