emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Update statistic cookies when archiving


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Update statistic cookies when archiving
Date: Sun, 03 Sep 2017 10:02:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hello,

Jay Kamat <address@hidden> writes:

> Sorry, forgot to actually attach the patch, here it is.
>
> From 95cdfa8c3ec81b3a0763b68044611c10a4dadc29 Mon Sep 17 00:00:00 2001
> From: Jay Kamat <address@hidden>
> Date: Sat, 2 Sep 2017 15:57:36 -0400
> Subject: [PATCH] org-archive.el: Update statistic cookies when
> archiving

Thank you!

Be warned that we're in a feature-freeze phase. It will have to wait for
Org 9.1 before being merged.

> +         ;; Go to parent, even if no children exist

Nitpick: Missing final dot.

> +         (org-up-heading-safe)
> +         ;; Update cookie of parent

Ditto.
> +         (org-update-statistics-cookies nil)))
>       (message "Subtree archived %s"
>                (if (eq this-buffer buffer)
>                    (concat "under heading: " heading)
> @@ -470,6 +476,9 @@ Archiving time is retained in the ARCHIVE_TIME node 
> property."
>       (outline-hide-subtree)
>       (org-cycle-show-empty-lines 'folded)
>       (goto-char pos)))
> +    (when org-provide-todo-statistics
> +      ;; update todo statistics of parent

Ditto. Missing capital, too.

> +      (org-update-parent-todo-statistics))
>      (org-reveal)
>      (if (looking-at "^[ \t]*$")
>       (outline-next-visible-heading 1))))

Could you provide some tests and an ORG-NEWS entry? For the latter, you
can start a new "Version 9.2" top heading.

Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]