[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] duplicated test names... are these bugs?
From: |
Nicolas Goaziou |
Subject: |
Re: [O] duplicated test names... are these bugs? |
Date: |
Fri, 08 Sep 2017 13:21:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello,
Stig Brautaset <address@hidden> writes:
>
> Running tests on master for me, with make test, results in a single test
> failure in `ob-shell/bash-uses-assoc-arrays'. While looking into that I
> found that there are _two_ definitions of that in the test-ob-shell.el
> file. This strikes me as unlikely to be ideal, and I decided to look a
> bit further and it turns out this is not unique. Running the following
> command from the top-level org-mode directory
>
> : $ ag --nogroup --nonumbers ert-deftest | sort | uniq -d
>
> Results in
>
> : testing/lisp/test-ob-lilypond.el:(ert-deftest ob-lilypond/ly-gen-html ()
> : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/bash-uses-assoc-arrays
> ()
> : testing/lisp/test-ob-shell.el:(ert-deftest
> ob-shell/generic-uses-no-assoc-arrays ()
> : testing/lisp/test-ob.el:(ert-deftest
> test-ob/commented-last-block-line-with-var ()
> : testing/lisp/test-ob.el:(ert-deftest
> test-ob/org-babel-remove-result--results-default ()
> : testing/lisp/test-ob.el:(ert-deftest
> test-ob/org-babel-remove-result--results-list ()
> : testing/lisp/test-ob.el:(ert-deftest
> test-ob/org-babel-remove-result--results-pp ()
> : testing/lisp/test-org-table.el:(ert-deftest test-org-table/align ()
>
> I'm not super familiar with ert, but I _assume_ that this will lead to
> only the last definition of the test with the duplicate names being run
> by 'make test'?
Fixed. Thank you.
Regards,
--
Nicolas Goaziou